New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CMCL-1542: Add option to decollide/deocclude towards follow target instead of LookAt target #945
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #945 +/- ##
==========================================
- Coverage 26.78% 26.74% -0.04%
==========================================
Files 247 247
Lines 27878 27894 +16
==========================================
- Hits 7466 7460 -6
- Misses 20412 20434 +22 ☔ View full report in Codecov by Sentry. |
f5844d0
to
98e3397
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No it's not. Looking into it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't look like it's related to deoccluder. Does it happen without the deoccluder? If so, it's a separate issue. |
Purpose of this PR
Currently, state.ReferenceLookAt is used for resolving occlusions, but sometimes people want to resolve based on the follow target instead.
Description here: https://forum.unity.com/threads/cinemachine-collider-target-follow-instead-of-lookat.1525138/
Testing status
Documentation status
Technical risk
low