Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMCL-1542: Add option to decollide/deocclude towards follow target instead of LookAt target #945

Merged
merged 53 commits into from Mar 28, 2024

Conversation

glabute
Copy link
Collaborator

@glabute glabute commented Mar 9, 2024

Purpose of this PR

Currently, state.ReferenceLookAt is used for resolving occlusions, but sometimes people want to resolve based on the follow target instead.

Description here: https://forum.unity.com/threads/cinemachine-collider-target-follow-instead-of-lookat.1525138/

image

Testing status

  • Added an automated test
  • Passed all automated tests
  • Manually tested

Documentation status

  • Updated CHANGELOG
  • Updated README (if applicable)
  • Commented all public classes, properties, and methods
  • Updated user documentation

Technical risk

low

@codecov-commenter
Copy link

codecov-commenter commented Mar 9, 2024

Codecov Report

Attention: Patch coverage is 49.09091% with 28 lines in your changes are missing coverage. Please review.

Project coverage is 26.74%. Comparing base (a497bbe) to head (592ef3c).

Files Patch % Lines
...achine/Runtime/Behaviours/CinemachineDecollider.cs 0.00% 15 Missing ⚠️
...achine/Runtime/Behaviours/CinemachineDeoccluder.cs 65.78% 13 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #945      +/-   ##
==========================================
- Coverage   26.78%   26.74%   -0.04%     
==========================================
  Files         247      247              
  Lines       27878    27894      +16     
==========================================
- Hits         7466     7460       -6     
- Misses      20412    20434      +22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@glabute glabute force-pushed the dev/decollide-towards-follow-target branch from f5844d0 to 98e3397 Compare March 27, 2024 11:49
@glabute glabute closed this Mar 27, 2024
@glabute glabute reopened this Mar 27, 2024
Copy link
Collaborator

@AntoineCharton AntoineCharton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it supposed to damp the target screen position?
Mar-27-2024 15-39-14
(Only happens when use follow target is enabled)

Base automatically changed from dev/actual-decollider to main March 27, 2024 20:21
@glabute
Copy link
Collaborator Author

glabute commented Mar 27, 2024

Is it supposed to damp the target screen position?

No it's not. Looking into it

Copy link
Collaborator

@AntoineCharton AntoineCharton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there! Should the screen position target do that?
Screenshot 2024-03-28 at 12 50 47 PM

Mar-28-2024 12-48-15

@glabute
Copy link
Collaborator Author

glabute commented Mar 28, 2024

Doesn't look like it's related to deoccluder. Does it happen without the deoccluder? If so, it's a separate issue.

@glabute glabute merged commit 3b0e21f into main Mar 28, 2024
9 checks passed
@glabute glabute deleted the dev/decollide-towards-follow-target branch March 28, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants