CMCL-0000: sync recentering with matching times #948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #948 +/- ##
=======================================
Coverage 26.80% 26.81%
=======================================
Files 250 250
Lines 27791 27804 +13
=======================================
+ Hits 7449 7455 +6
- Misses 20342 20349 +7 ☔ View full report in Codecov by Sentry. |
| PanAxis.UpdateRecentering(deltaTime, PanAxis.TrackValueChange()); | ||
| TiltAxis.UpdateRecentering(deltaTime, TiltAxis.TrackValueChange()); | ||
| var gotInputX = PanAxis.TrackValueChange(); | ||
| var gotInputY = TiltAxis.TrackValueChange(); |
There was a problem hiding this comment.
What happens with the radial axis?
There was a problem hiding this comment.
There is no radial axis in PanTilt
AntoineCharton
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Axis recentering happens independently on axes with differing recentering tmes, so that input on one axis does not impact the recentering state of the others.
note: This should be backported to 3.0 branch - done
Testing status