Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMCL-1574: zero member targetgroup behaves better #954

Merged
merged 4 commits into from Apr 4, 2024

Conversation

glabute
Copy link
Collaborator

@glabute glabute commented Mar 18, 2024

Purpose of this PR

CMCL-1574:
When all members of a target group are disabled, target group should retain its most recent valid position and dimensions, to avoid camera pops.

This fixes a regression reported in CMCL-1574

Testing status

  • Added an automated test
  • Passed all automated tests
  • Manually tested

Documentation status

  • Updated CHANGELOG
  • Updated README (if applicable)
  • Commented all public classes, properties, and methods
  • Updated user documentation

Technical risk

low

@@ -7,6 +7,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.

## [Unreeleased] - 2024-01-02
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## [Unreeleased] - 2024-01-02
## [2.11.0] - 2024-01-02

To fix the tests

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, done

@codecov-commenter
Copy link

codecov-commenter commented Mar 27, 2024

Codecov Report

Attention: Patch coverage is 0% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 26.55%. Comparing base (e3c265f) to head (434d774).
Report is 1 commits behind head on release/2.10.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##           release/2.10     #954   +/-   ##
=============================================
  Coverage         26.54%   26.55%           
=============================================
  Files               126      126           
  Lines             18893    18889    -4     
=============================================
  Hits               5016     5016           
+ Misses            13877    13873    -4     
Files Coverage Δ
...chine/Runtime/Behaviours/CinemachineTargetGroup.cs 0.00% <0.00%> (ø)

Copy link
Collaborator

@AntoineCharton AntoineCharton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug is fixed.

@glabute glabute merged commit 515188c into release/2.10 Apr 4, 2024
28 checks passed
@glabute glabute deleted the dev/zero-member-targetgroup-behaves-better branch April 4, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants