New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CMCL-1574: zero member targetgroup behaves better #954
CMCL-1574: zero member targetgroup behaves better #954
Conversation
…valid dimensions.
com.unity.cinemachine/CHANGELOG.md
Outdated
@@ -7,6 +7,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0. | |||
|
|||
## [Unreeleased] - 2024-01-02 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
## [Unreeleased] - 2024-01-02 | |
## [2.11.0] - 2024-01-02 |
To fix the tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, done
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## release/2.10 #954 +/- ##
=============================================
Coverage 26.54% 26.55%
=============================================
Files 126 126
Lines 18893 18889 -4
=============================================
Hits 5016 5016
+ Misses 13877 13873 -4
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug is fixed.
Purpose of this PR
CMCL-1574:
When all members of a target group are disabled, target group should retain its most recent valid position and dimensions, to avoid camera pops.
This fixes a regression reported in CMCL-1574
Testing status
Documentation status
Technical risk
low