Migrate from IPostGenerateGradleAndroidProject->AndroidProjectFilesModifier #301
Conversation
| } | ||
| public class AndroidNotificationPostProcessor : AndroidProjectFilesModifier | ||
| { | ||
| private static readonly string NotificationProguardPath = "unityLibrary/proguard-unity-notifications.txt"; |
There was a problem hiding this comment.
Not we're creating new proguard for notifications, since we don't allow updating existing proguard-unity, since it's not incremental friendly way
| var receiverkNotificationManager = new Receiver(); | ||
| receiverkNotificationManager.Attributes.Name.Set("com.unity.androidnotifications.UnityNotificationManager"); | ||
| receiverkNotificationManager.Attributes.Exported.Set(false); | ||
| manifest.Application.ReceiverList.AddElement(receiverkNotificationManager); |
There was a problem hiding this comment.
@rytis can you comment on this one, is it's correct way to add receiver element ?
I was hoping for manifest.Application.ReceiverList.AddReceiver/Add(string name)
There was a problem hiding this comment.
Yes, it is correct. If you'd add a helper API, it should be added to the Application: manifest.Application.AddReceiver(). One concern would be that Receiver has a lot of fields. Do you think Name and Exported fields would be the most commonly used? Otherwise I don't think the helper method is very helpful
| if ((settings.ExactAlarm & AndroidExactSchedulingOption.AddRequestIgnoreBatteryOptimizationsPermission) != 0) | ||
| { | ||
| // TODO: Missing AddUsesPermissionSdk23 function | ||
| var batterOptimizations = manifest.AddUsesPermission("android.permission.REQUEST_IGNORE_BATTERY_OPTIMIZATIONS"); |
There was a problem hiding this comment.
@rytis-buz would it makese sense to have AddUsesPermissionSdk23 function?
| { | ||
| // TODO: PropertyStringArray missing Add function? | ||
| var original = new List<string>(projectFiles.UnityLibraryBuildGradle.Android.DefaultConfig.ConsumerProguardFiles.Get()); | ||
| original.Add(Path.GetFileName(NotificationProguardPath)); |
There was a problem hiding this comment.
@rytis-buz would it make sense to have projectFiles.UnityLibraryBuildGradle.Android.DefaultConfig.ConsumerProguardFiles.Add(string value) to append to array?
| var receiverkNotificationManager = new Receiver(); | ||
| receiverkNotificationManager.Attributes.Name.Set("com.unity.androidnotifications.UnityNotificationManager"); | ||
| receiverkNotificationManager.Attributes.Exported.Set(false); | ||
| manifest.Application.ReceiverList.AddElement(receiverkNotificationManager); |
There was a problem hiding this comment.
Yes, it is correct. If you'd add a helper API, it should be added to the Application: manifest.Application.AddReceiver(). One concern would be that Receiver has a lot of fields. Do you think Name and Exported fields would be the most commonly used? Otherwise I don't think the helper method is very helpful
| if ((settings.ExactAlarm & AndroidExactSchedulingOption.AddRequestIgnoreBatteryOptimizationsPermission) != 0) | ||
| { | ||
| // TODO: Missing AddUsesPermissionSdk23 function | ||
| var batterOptimizations = manifest.AddUsesPermission("android.permission.REQUEST_IGNORE_BATTERY_OPTIMIZATIONS"); |
| { | ||
| // TODO: PropertyStringArray missing Add function? | ||
| var original = new List<string>(projectFiles.UnityLibraryBuildGradle.Android.DefaultConfig.ConsumerProguardFiles.Get()); | ||
| original.Add(Path.GetFileName(NotificationProguardPath)); |
No description provided.