Feature/player persistence base foundation #342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…runtime lists & associated assets)
fernando-cortez
added
the
1-Needs Review
| /// this connection, meaning it will persist between scenes. | ||
| /// </summary> | ||
| [RequireComponent(typeof(NetworkObject))] | ||
| public class BossRoomPlayer : NetworkBehaviour |
There was a problem hiding this comment.
Has since been renamed.
| /// A runtime list of <see cref="BossRoomPlayer"/> objects that is populated both on clients and server. | ||
| /// </summary> | ||
| [CreateAssetMenu] | ||
| public class BossRoomPlayerRuntimeCollection : RuntimeCollection<BossRoomPlayer> |
There was a problem hiding this comment.
PersistentPlayerRuntimeCollection
There was a problem hiding this comment.
Has since been renamed.
SamuelBellomo
approved these changes
Jun 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira task here.
Changes:
Introduction of
PersistentPlayerNetworkBehaviour.PersistentPlayerwill be attached to MLAPI's "Default Player Prefab" (coming in a subsequent PR) and will persist throughout scene changes for the duration of a connection.Introduction of
ScriptableObjectruntime sets, namelyPersistentPlayerRuntimeCollectionandServerCharacterRuntimeCollection, where the former is populated on both clients and server while the latter is populated only on the server. This is will be referenced in several state prefabs, and the Player/PlayerCharacter prefabs themselves, with the goal being removing hard references between systems (eg. Players and UI).