Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

radio button introduced for main menu UX improvements (default is still IP) #345

Merged
merged 3 commits into from
Jun 4, 2021

Conversation

fernando-cortez
Copy link
Collaborator

@fernando-cortez fernando-cortez commented May 28, 2021

Jira task here.

The attached screenshot should provide more information than the summary :).
image

Changes:

  • Added a Toggle Group parent to PopupPanel prefab, with toggles for each connection type (IP & relay).
  • Added a bit more instructive text to hosting (both on IP and Relay).

@fernando-cortez fernando-cortez added the 1-Needs Review PR needs attention from the assignee and reviewers label May 28, 2021
@@ -0,0 +1,51 @@
using System;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, let's try using toggle groups instead of having our own implementation

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@fernando-cortez fernando-cortez added the 2-Easy This PR is trivial and can be reviewed quickly label May 28, 2021
@SamuelBellomo SamuelBellomo merged commit ad67721 into develop Jun 4, 2021
@SamuelBellomo SamuelBellomo deleted the feature/main-menu-screen-ux-improvements branch June 4, 2021 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1-Needs Review PR needs attention from the assignee and reviewers 2-Easy This PR is trivial and can be reviewed quickly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants