Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

archer's base attack & charged shot 1-3 use NetworkTransform #353

Merged
merged 1 commit into from
Jun 17, 2021
Merged

archer's base attack & charged shot 1-3 use NetworkTransform #353

merged 1 commit into from
Jun 17, 2021

Conversation

fernando-cortez
Copy link
Collaborator

@fernando-cortez fernando-cortez commented Jun 16, 2021 •
edited
Loading

Jira task here.

  • Arrow, ChargedArrow1, ChargedArrow2, ChargedArrow3 have now a NetworkTransform component, while ClientGenericMovement has been removed.
  • NetworkVariables for position, rotation & speed have been removed from NetworkProjectileState.
  • NetworkTransform component's Fixed Sends Per Second is set to 50 and Channel is set to Position Update.
  • Arrow prefab wasn't using the generic FX_arrow graphics prefab for its client side visualization, so that's been fixed for parity across arrows.
  • Removed shadow casting on arrow visualization prefabs.

@fernando-cortez fernando-cortez added the 1-Needs Review PR needs attention from the assignee and reviewers label Jun 16, 2021
@fernando-cortez fernando-cortez merged commit d3b81dc into develop Jun 17, 2021
@fernando-cortez fernando-cortez deleted the feature/arrows-using-networktransform branch June 17, 2021 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cosmin-B Cosmin-B Cosmin-B approved these changes

@SamuelBellomo SamuelBellomo SamuelBellomo approved these changes

Assignees

@Cosmin-B Cosmin-B

@SamuelBellomo SamuelBellomo

Labels
1-Needs Review PR needs attention from the assignee and reviewers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fernando-cortez @Cosmin-B @SamuelBellomo