Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Netcode rebranding #368

Merged
merged 6 commits into from
Sep 23, 2021
Merged

feat: Netcode rebranding #368

merged 6 commits into from
Sep 23, 2021

Conversation

fernando-cortez
Copy link
Collaborator

@fernando-cortez fernando-cortez commented Sep 15, 2021 •
edited
Loading

Jira task for rebranding here.

In this PR:

  • Mentions of MLAPI in comments now refer to Netcode.
  • Namespaces have been renamed. Example: BossRoom -> Unity.Multiplayer.Samples.BossRoom.
  • Assembly definition files have been renamed to match Netcode's. Example: BossRoom.Client -> com.unity.multiplayer.samples.bossroom.client.
  • Repo, package, and template readme updated.

@fernando-cortez fernando-cortez added the 1-Needs Review PR needs attention from the assignee and reviewers label Sep 15, 2021
SamuelBellomo
SamuelBellomo previously approved these changes Sep 16, 2021
View reviewed changes
Copy link
Contributor

@SamuelBellomo SamuelBellomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@fernando-cortez fernando-cortez added 2-One More Review One review in, one to go and removed 1-Needs Review PR needs attention from the assignee and reviewers labels Sep 16, 2021
pdeschain
pdeschain previously approved these changes Sep 17, 2021
View reviewed changes
@pdeschain pdeschain added 3-Good to Merge and removed 2-One More Review One review in, one to go labels Sep 17, 2021
SamuelBellomo
SamuelBellomo reviewed Sep 20, 2021
View reviewed changes
README.md Outdated Show resolved Hide resolved
SamuelBellomo
SamuelBellomo previously approved these changes Sep 20, 2021
View reviewed changes
@fernando-cortez fernando-cortez merged commit e8f3f9f into develop Sep 23, 2021
@fernando-cortez fernando-cortez deleted the feature/netcode-rebranding branch September 23, 2021 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pdeschain pdeschain pdeschain approved these changes

@SamuelBellomo SamuelBellomo SamuelBellomo approved these changes

Assignees

@Cosmin-B Cosmin-B

@SamuelBellomo SamuelBellomo

Labels
3-Good to Merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@fernando-cortez @pdeschain @SamuelBellomo @Cosmin-B