Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: NetworkTransform configurations to reduce bandwidth usage [MTT-1203] #716

Merged
merged 10 commits into from
Aug 26, 2022

Conversation

LPLafontaineB
Copy link
Contributor

Description

Currently, we are synchronizing a lot of data through our NetworkTransform components that doesn't need to be synchronized. For example, characters synchronize their position, rotation and scale in their entirety, which leads to updates of 47B each time they are moving.
This PR reduces the bandwidth used by configuring our NetworkTransform components on our different NetworkObjects to only synchronize what is needed. For characters, pickable pots and arrows, this means the (x,z) components of their position and the (y) component of their rotation. For tossed items, this means everything except the scale.
To use the characters as an example again, this reduces the size of the updates to only 23B.

This PR also restores the default thresholds used to determine when a synchronization is needed.

Issue Number(s)

MTT-1203

Contribution checklist

  • Tests have been added for boss room and/or utilities pack
  • Release notes have been added to the project changelog file and/or package changelog file
  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • JIRA ticket ID is in the PR title or at least one commit message
  • Include the ticket ID number within the body message of the PR to create a hyperlink

@LPLafontaineB LPLafontaineB added 2-Easy This PR is trivial and can be reviewed quickly 1-Needs Review PR needs attention from the assignee and reviewers labels Aug 24, 2022
@LPLafontaineB LPLafontaineB marked this pull request as ready for review August 24, 2022 15:24
pdeschain
pdeschain previously approved these changes Aug 24, 2022
@pdeschain pdeschain added 2-One More Review One review in, one to go and removed 1-Needs Review PR needs attention from the assignee and reviewers labels Aug 24, 2022
@fernando-cortez fernando-cortez added 3-Good to Merge and removed 2-One More Review One review in, one to go labels Aug 24, 2022
@LPLafontaineB LPLafontaineB enabled auto-merge (squash) August 24, 2022 17:30
CHANGELOG.md Outdated Show resolved Hide resolved
@fernando-cortez fernando-cortez added 3-Good to Merge and removed 2-One More Review One review in, one to go labels Aug 26, 2022
@LPLafontaineB LPLafontaineB enabled auto-merge (squash) August 26, 2022 14:56
@LPLafontaineB LPLafontaineB merged commit 16963d6 into develop Aug 26, 2022
@LPLafontaineB LPLafontaineB deleted the feature/nettransform-configuration branch August 26, 2022 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2-Easy This PR is trivial and can be reviewed quickly 3-Good to Merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants