-
Notifications
You must be signed in to change notification settings - Fork 489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: NetworkTransform configurations to reduce bandwidth usage [MTT-1203] #716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng scale sync from impTossedItem
LPLafontaineB
added
2-Easy
This PR is trivial and can be reviewed quickly
1-Needs Review
PR needs attention from the assignee and reviewers
labels
Aug 24, 2022
pdeschain
previously approved these changes
Aug 24, 2022
pdeschain
added
2-One More Review
One review in, one to go
and removed
1-Needs Review
PR needs attention from the assignee and reviewers
labels
Aug 24, 2022
fernando-cortez
previously approved these changes
Aug 24, 2022
fernando-cortez
added
3-Good to Merge
and removed
2-One More Review
One review in, one to go
labels
Aug 24, 2022
…om/Unity-Technologies/com.unity.multiplayer.samples.coop into feature/nettransform-configuration
LPLafontaineB
dismissed stale reviews from fernando-cortez and pdeschain
via
August 24, 2022 18:10
77806b0
SamuelBellomo
approved these changes
Aug 26, 2022
LPLafontaineB
added
2-One More Review
One review in, one to go
and removed
3-Good to Merge
labels
Aug 26, 2022
fernando-cortez
approved these changes
Aug 26, 2022
fernando-cortez
added
3-Good to Merge
and removed
2-One More Review
One review in, one to go
labels
Aug 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, we are synchronizing a lot of data through our NetworkTransform components that doesn't need to be synchronized. For example, characters synchronize their position, rotation and scale in their entirety, which leads to updates of 47B each time they are moving.
This PR reduces the bandwidth used by configuring our NetworkTransform components on our different NetworkObjects to only synchronize what is needed. For characters, pickable pots and arrows, this means the (x,z) components of their position and the (y) component of their rotation. For tossed items, this means everything except the scale.
To use the characters as an example again, this reduces the size of the updates to only 23B.
This PR also restores the default thresholds used to determine when a synchronization is needed.
Issue Number(s)
MTT-1203
Contribution checklist