Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: wrong base class for ClientConnectedState [MTT-5293] #801

Merged
merged 4 commits into from
Jan 6, 2023
Merged

fix: wrong base class for ClientConnectedState [MTT-5293] #801

merged 4 commits into from
Jan 6, 2023

Conversation

LPLafontaineB
Copy link
Contributor

@LPLafontaineB LPLafontaineB commented Jan 6, 2023 •
edited
Loading

Description

This fixes the ClientConnectedState class having the wrong base class. It now properly inherits from OnlineState instead of the base ConnectionState. This PR also moves the k_DtlsConnType constant to the ConnectionMethod class, where it is actually used.

Issue Number(s)

MTT-5293

Contribution checklist

  • Tests have been added for boss room and/or utilities pack
  • Release notes have been added to the project changelog file and/or package changelog file
  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • JIRA ticket ID is in the PR title or at least one commit message
  • Include the ticket ID number within the body message of the PR to create a hyperlink
  • An Index entry has been added in readme.md if applicable

@LPLafontaineB LPLafontaineB added 2-Easy This PR is trivial and can be reviewed quickly 1-Needs Review PR needs attention from the assignee and reviewers labels Jan 6, 2023
@LPLafontaineB LPLafontaineB marked this pull request as ready for review January 6, 2023 18:40
@LPLafontaineB LPLafontaineB merged commit bcac45b into develop Jan 6, 2023
@LPLafontaineB LPLafontaineB deleted the fix/client-connected-state-wrong-baseclass branch January 6, 2023 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SamuelBellomo SamuelBellomo SamuelBellomo approved these changes

Assignees
No one assigned
Labels
1-Needs Review PR needs attention from the assignee and reviewers 2-Easy This PR is trivial and can be reviewed quickly
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@LPLafontaineB @SamuelBellomo