-
Notifications
You must be signed in to change notification settings - Fork 480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: upgrade to NGO v1.8.1, conversion to universal Rpcs, utility assembly includes Unity.Collections [MTT-8188] #883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… includes Unity.Collections
fernando-cortez
commented
Mar 18, 2024
Assets/Scripts/ConnectionManagement/ConnectionState/ClientConnectedState.cs
Show resolved
Hide resolved
fernando-cortez
changed the title
feat: upgrade to NGO v1.8.1, conversion to universal Rpcs, utility assembly includes Unity.Collections
feat: upgrade to NGO v1.8.1, conversion to universal Rpcs, utility assembly includes Unity.Collections [MTT-8188]
Mar 19, 2024
fernando-cortez
added
the
1-Needs Review
PR needs attention from the assignee and reviewers
label
Mar 19, 2024
NoelStephensUnity
requested changes
Mar 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left one comment that should apply to all updated Rpcs.
Assets/Scripts/ConnectionManagement/ConnectionState/ClientConnectedState.cs
Show resolved
Hide resolved
Packages/com.unity.multiplayer.samples.coop/Utilities/SceneManagement/SceneLoaderWrapper.cs
Outdated
Show resolved
Hide resolved
NoelStephensUnity
previously approved these changes
Mar 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Packages/com.unity.multiplayer.samples.coop/Utilities/SceneManagement/SceneLoaderWrapper.cs
Outdated
Show resolved
Hide resolved
RikuTheFuffs
approved these changes
Mar 22, 2024
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR upgrades to Netcode for GameObjects v1.8.1, and also upgrades the Rpcs used inside the project to the newer API, Universal Rpcs.
Note: along the way, I've had to modify ClientConnectedState. A recent commit to Netcode for GameObjects has added this change to a host/server's disconnect logic:
Basically, when you shutdown a server/host during an in-progress network session the server/host will send disconnect messages and will wait for a period of time for all connected clients to disconnect or if it times out it will just finalize the shutdown sequence.
Where a connected client had previously assumed that a host's disconnect would produce an empty DisconnectReason string, we now have one sent to disconnected clients. This string has appropriately been checked against inside
ClientConnectedState
, which fixed a failing test (due to the assumption listed).Issue Number(s)
MTT-8188
Contribution checklist