Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade to NGO v1.8.1, conversion to universal Rpcs, utility assembly includes Unity.Collections [MTT-8188] #883

Merged
merged 9 commits into from
Mar 22, 2024

Conversation

fernando-cortez
Copy link
Collaborator

@fernando-cortez fernando-cortez commented Mar 15, 2024

Description

This PR upgrades to Netcode for GameObjects v1.8.1, and also upgrades the Rpcs used inside the project to the newer API, Universal Rpcs.

Note: along the way, I've had to modify ClientConnectedState. A recent commit to Netcode for GameObjects has added this change to a host/server's disconnect logic:

  • Basically, when you shutdown a server/host during an in-progress network session the server/host will send disconnect messages and will wait for a period of time for all connected clients to disconnect or if it times out it will just finalize the shutdown sequence.

Where a connected client had previously assumed that a host's disconnect would produce an empty DisconnectReason string, we now have one sent to disconnected clients. This string has appropriately been checked against inside ClientConnectedState, which fixed a failing test (due to the assumption listed).

Issue Number(s)

MTT-8188

Contribution checklist

  • Tests have been added for boss room and/or utilities pack
  • Release notes have been added to the project changelog file and/or package changelog file
  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • JIRA ticket ID is in the PR title or at least one commit message
  • Include the ticket ID number within the body message of the PR to create a hyperlink
  • An Index entry has been added in readme.md if applicable

@unity-cla-assistant
Copy link

unity-cla-assistant commented Mar 15, 2024

CLA assistant check
All committers have signed the CLA.

@fernando-cortez fernando-cortez changed the title feat: upgrade to NGO v1.8.1, conversion to universal Rpcs, utility assembly includes Unity.Collections feat: upgrade to NGO v1.8.1, conversion to universal Rpcs, utility assembly includes Unity.Collections [MTT-8188] Mar 19, 2024
@fernando-cortez fernando-cortez added the 1-Needs Review PR needs attention from the assignee and reviewers label Mar 19, 2024
@fernando-cortez fernando-cortez marked this pull request as ready for review March 19, 2024 18:32
@fernando-cortez fernando-cortez requested a review from a team as a code owner March 19, 2024 18:32
Copy link
Contributor

@NoelStephensUnity NoelStephensUnity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one comment that should apply to all updated Rpcs.

Copy link
Contributor

@NoelStephensUnity NoelStephensUnity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!
:godmode:

@fernando-cortez fernando-cortez merged commit 8160543 into develop Mar 22, 2024
13 checks passed
@fernando-cortez fernando-cortez deleted the feat/universal-rpc-upgrade branch March 22, 2024 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1-Needs Review PR needs attention from the assignee and reviewers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants