Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade to 2022.3.22f1 LTS [MTT-8194] [MTT-8160] #884

Merged
merged 4 commits into from
Apr 8, 2024

Conversation

fernando-cortez
Copy link
Collaborator

@fernando-cortez fernando-cortez commented Mar 25, 2024

Description

This PR upgrades the project to the newest LTS (2022.3.22f1).

Included in this PR too is Yamato tests being re-enabled for 2022.3.x. It was previously fixed for a certain version but now Yamato tests will use the latest 2022.3 LTS version available.

One last thing is a fix inside ClientLoadingScreen.cs, where a null reference exception was being triggered when a LoadingProgressManager instance was being destroyed before ClientLoadingScreen.

Issue Number(s)

MTT-8194
MTT-8160

Contribution checklist

  • [ N/A ] Tests have been added for boss room and/or utilities pack
  • Release notes have been added to the project changelog file and/or package changelog file
  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • JIRA ticket ID is in the PR title or at least one commit message
  • Include the ticket ID number within the body message of the PR to create a hyperlink
  • [ N/A ] An Index entry has been added in readme.md if applicable

@fernando-cortez fernando-cortez added 2-Easy This PR is trivial and can be reviewed quickly 1-Needs Review PR needs attention from the assignee and reviewers labels Mar 25, 2024
@fernando-cortez fernando-cortez marked this pull request as ready for review March 25, 2024 19:29
@fernando-cortez fernando-cortez requested a review from a team as a code owner March 25, 2024 19:29
@Elfi0Kuhndorf
Copy link
Contributor

Elfi0Kuhndorf commented Mar 26, 2024

I was testing the branch with multiple builds and I got the following errors when all the party members got defeated and starting a new session afterwards, and trying to join with another player as host (so most of the errors are expected I assume):
image

Also when trying to start clones over ParrelSync it had a lot compiler issues not recognizing the new package (even when creating a new clone), but that might be a parrel sync issue.

@fernando-cortez
Copy link
Collaborator Author

@Elfi0Kuhndorf I pushed up a fix for the ClientLoadingScreen issue. Could you retest the condition that brought up the error?

As for the second ParrelSync item, let's create a task for that with the logs that it generates, since I can't seem to reproduce ParrelSync errors. We'll address that in a new PR.

@fernando-cortez fernando-cortez changed the title feat: upgrade to 2022.3.22f1 LTS [MTT-8194] feat: upgrade to 2022.3.22f1 LTS [MTT-8194] [MTT-8160] Mar 26, 2024
@Elfi0Kuhndorf
Copy link
Contributor

Elfi0Kuhndorf commented Mar 27, 2024

@Elfi0Kuhndorf I pushed up a fix for the ClientLoadingScreen issue. Could you retest the condition that brought up the error?

As for the second ParrelSync item, let's create a task for that with the logs that it generates, since I can't seem to reproduce ParrelSync errors. We'll address that in a new PR.

Thanks! I will test if the issues still comes up.

Regarding the Parrel Sync Issue I will try to reproduce it and if it occurs again make a ticket out of it.
EDIT: was not able to reproduce parrel sync issue

@fernando-cortez fernando-cortez merged commit 55a56be into develop Apr 8, 2024
13 checks passed
@fernando-cortez fernando-cortez deleted the feat/upgrade-to-2022.3.22f1LTS branch April 8, 2024 14:37
@Elfi0Kuhndorf
Copy link
Contributor

I tested if the Null Reference Exeption still comes up and it did not, the issue seems fixed.

@fernando-cortez fernando-cortez mentioned this pull request Apr 18, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1-Needs Review PR needs attention from the assignee and reviewers 2-Easy This PR is trivial and can be reviewed quickly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants