Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: NetworkBehaviour.IsSpawned #1190

Merged
merged 3 commits into from Sep 16, 2021

Conversation

NoelStephensUnity
Copy link
Collaborator

This allows a user to determine if the associated NetworkObject is considered spawned or not without having to check the NetworkObject first (which can, under specific conditions, generate a warning message).

Adding the IsSpawned bool value that is set when the InternalOnNetworkSpawn method is invoked and unset when the InternalOnNetworkDespawn method is invoked.
A better way.
Replacing LF so it is exactly as it was.
@NoelStephensUnity NoelStephensUnity merged commit 5114ca8 into develop Sep 16, 2021
@NoelStephensUnity NoelStephensUnity deleted the feat/networkbehaviour-IsSpawned branch September 16, 2021 01:26
SamuelBellomo added a commit that referenced this pull request Sep 16, 2021
…nsform

* develop:
  feat: NetworkBehaviour.IsSpawned  (#1190)
  feat: added tip to the network manager inspector that directs to install tools (MTT-1211) (#1182)
  refactor!: remove network dictionary & set, use native container in List, add tests (#1149)
  fix: Fixed remote disconnects not properly cleaning up (#1184)
  test: base changes to PR-1114 (#1165)
  test: verify do not destroy networkobjects on networkmanager shutdown (#1183)
  chore: removal of EnableNetworkVariable in NetworkConfig. It's always True now (#1179)
  fix: Fix DontDestroyWithOwner not returning ownership (#1181)
  test: Giving Android some more room as the connection tests are timing sensitive (#1178)
  fix: unitytransport connectionmode buttons (#1176)
  test: added min frames to multi-instance helper (#1170)
  chore: Add mobile tests to nightly trigger (#1161)
  feat: snapshot spawn pre-requisite (#1166)
  feat: Unity Transport + Relay (#887)
  feat: client scene synchronization mode (#1171)

# Conflicts:
#	testproject/Assets/Scenes/SampleScene.unity
SamuelBellomo added a commit that referenced this pull request Sep 16, 2021
…am/feature/client-network-transform

* sam/feature/interpolation-for-network-transform: (22 commits)
  fixing line issue
  more formatting
  fixing formatting issue
  removing not submitted LiteNetLib from ZooSam
  feat: Fast buffer reader and fast buffer writer (#1082)
  restricting public api
  bumping exec order
  feat: NetworkBehaviour.IsSpawned  (#1190)
  feat: added tip to the network manager inspector that directs to install tools (MTT-1211) (#1182)
  refactor!: remove network dictionary & set, use native container in List, add tests (#1149)
  fix: Fixed remote disconnects not properly cleaning up (#1184)
  test: base changes to PR-1114 (#1165)
  test: verify do not destroy networkobjects on networkmanager shutdown (#1183)
  chore: removal of EnableNetworkVariable in NetworkConfig. It's always True now (#1179)
  fix: Fix DontDestroyWithOwner not returning ownership (#1181)
  test: Giving Android some more room as the connection tests are timing sensitive (#1178)
  fix: unitytransport connectionmode buttons (#1176)
  test: added min frames to multi-instance helper (#1170)
  chore: Add mobile tests to nightly trigger (#1161)
  feat: snapshot spawn pre-requisite (#1166)
  ...

# Conflicts:
#	com.unity.netcode.gameobjects/Components/NetworkTransform.cs
#	testproject/Assets/Scenes/SampleScene.unity
mollstam pushed a commit to Keepsake-Games/com.unity.netcode.gameobjects that referenced this pull request Feb 13, 2023
* feat

Adding the IsSpawned bool value that is set when the InternalOnNetworkSpawn method is invoked and unset when the InternalOnNetworkDespawn method is invoked.

* refactor

A better way.

* style

Replacing LF so it is exactly as it was.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants