fix: NCCBUG-193 #2492
Merged
fix: NCCBUG-193 #2492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ated transitions (#2481) * fix For client authoritative, the server now actually sends any pending animation updates to any non-authoritative clients. Trigger not updating properly on server when server authoritative but was the owner sending the trigger update. Improve detection of the type of animation state change. This fixes the issue where cross fades were not being handled by NetworkAnimator. This is a first pass fix and the serialization could use an overhaul to reduce bandwidth costs. * update Making sure we don't toggle between transition and crossfade. Packing values for AnimationState Updating the manual test used to get cross fading to AnimationStates without transitions working. Making the serialization of the two bools one byte instead of two bytes. * test Adding some cross fade tests to the NetworkAnimatorTests. Also fixed an issue with the coroutineRunner being destroyed before the IntegrationTestSceneHandler was. This is the final test for cross fade initiated transitions and whether it is detected and synchronized or not.
ShadauxCat
approved these changes
Apr 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass the actual ClientRpcParams into the SendAnimStateClientRpc method.
Changelog
NetworkAnimatorwas building client RPC parameters to exclude the host from sending itself messages but was not including it in the ClientRpc parameters.