New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: GlobalObjectidHash serializing invalid values [MTT-77098] #2662
Merged
NoelStephensUnity
merged 16 commits into
develop
from
fix/globalobjectidhash-serializing-invalid-values-mtt-77098
Aug 25, 2023
Merged
fix: GlobalObjectidHash serializing invalid values [MTT-77098] #2662
NoelStephensUnity
merged 16 commits into
develop
from
fix/globalobjectidhash-serializing-invalid-values-mtt-77098
Aug 25, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WIP: So far this user suggested fix looks promising. Creating a prefab from within a scene no longer requires one to delete the original (in-scene) object and then create a new instance from the newly created prefab. It also is automatically detected and added to the default prefabs. Still needs further testing and investigation.
This reverts commit c1eda40.
…7098' of https://github.com/Unity-Technologies/com.unity.netcode.gameobjects into fix/globalobjectidhash-serializing-invalid-values-mtt-77098
samlucas-unity
approved these changes
Aug 25, 2023
adding one more entry
Merged
3 tasks
NoelStephensUnity
deleted the
fix/globalobjectidhash-serializing-invalid-values-mtt-77098
branch
August 25, 2023 19:37
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves several issues with the generation of the
GlobalObjectIdHash
value:GlobalObjectIdHash
value could be serialized.GlobalObjectIdHash
value to be updated but the asset not marked as being dirty.GlobalObjectIdHash
value.MTT-7098
fix: #2653
fix: #1499
fix: #2664
Changelog
DefaultNetworkPrefabs
asset was not enabled by default.GlobalObjectIdHash
value could be updated but the asset not marked as dirty.GlobalObjectIdHash
value of a (network) prefab asset could be assigned an incorrect value when editing the prefab in a temporary scene.GlobalObjectIdHash
value generated after creating a (network) prefab from an object constructed within the scene would not be the correct final value in a stand alone build.Testing and Documentation