Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: SpawnWithObservers not honored when EnableSceneManagement is disabled [MTT-7237] #2682

Merged

Conversation

NoelStephensUnity
Copy link
Collaborator

This fixes the issue where the SpawnWithObservers check was not implemented within ConnectionApprovedMessage when scene management is disabled.

MTT-7237

fix: #2680

Changelog

  • Fixed: issue where SpawnWithObservers was not being honored when NetworkConfig.EnableSceneManagement was disabled.

Testing and Documentation

  • Includes update to NetworkObjectOnSpawnTests.ObserverSpawnTests to validate this fix.
  • No documentation changes or additions were necessary.

MTT-7237

Include the SpawnWithObservers check when scene management is disabled.
Extending the ObserverSpawnTests to run a pass with scene management disabled.
@NoelStephensUnity NoelStephensUnity requested a review from a team as a code owner August 29, 2023 20:12
Adding change log entry.
@NoelStephensUnity NoelStephensUnity merged commit f890d7e into develop Aug 30, 2023
23 checks passed
@NoelStephensUnity NoelStephensUnity deleted the fix/spawnwithobservers-scenemanagement-disabled branch August 30, 2023 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SpawnWithObservers set to false, but network object spawns on later joined clients
2 participants