fix: in-scene parenting WorldPositionStays transform synchronization without NetworkTransform [MTT-7856] #2796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the issue with World Position Stays being set not working along this: - The integration scene names not being added with complex nested children - Parents and children were not being ordered as parent first then child But now that this is fixed, the world position stays set to false no longer works (whack a mole).
NoelStephensUnity
changed the title
ShadauxCat
reviewed
Dec 20, 2023
ShadauxCat
reviewed
Dec 20, 2023
ShadauxCat
approved these changes
Feb 1, 2024
NoelStephensUnity
deleted the
fix/in-scene-parenting-worldpositionstays-setting-no-nt
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves an issue discovered with in-scene placed
NetworkObjects where complex nested parent-child hierarchies would not synchronize properly when parenting changed usingWorldPositionStaysset to true. This also resolves an issue where the initial synchronization was not orderingNetworkObjects with parents before children with complex nested parent-child hierarchies. This update assures the parents will always proceed the children in the initial synchronization serializedNetworkObjectorder.MTT-7856
Changelog
NetworkObjects with complex nested childrenNetworkObjects (more than one child in depth) would not synchronize properly ifWorldPositionStayswas set to true.Testing and Documentation
InSceneParentChildHandlerintegration test helper component.