Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix building runtime editing example to standalone #199

Merged
merged 5 commits into from Oct 8, 2019

Conversation

karl-
Copy link
Contributor

@karl- karl- commented Aug 28, 2019

https://fogbugz.unity3d.com/f/cases/1165683

Fixes issues when building the runtime editing example to a player.

  • Missing references to materials and shaders
  • An uninitialized lookup dictionary
  • Add a readme for a common mistake (forgetting to disable script stripping)

@gabrielw-us
Copy link
Contributor

gabrielw-us commented Aug 28, 2019

Some issues, using 19.3.0b1 -

In the standalone build, click-drag on face just pans my camera
In the editor Play mode, click-drag works to move faces, but I see an enormous axis indicator

image

@karl-
Copy link
Contributor Author

karl- commented Aug 29, 2019

In the standalone build, click-drag on face just pans my camera

You have to disable "Script Stripping" in the ProBuilder preferences for this example to work. It's mentioned in the new readme.

In the editor Play mode, click-drag works to move faces, but I see an enormous axis indicator

@gabrielw-us
Copy link
Contributor

🤦‍♂ of course, and you just mentioned that the other day :D

re-checking 👍

@karl-
Copy link
Contributor Author

karl- commented Aug 29, 2019

@gabrielw-us c75908d sets a reasonable line width

Copy link
Contributor

@JoelFortin JoelFortin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me ... please make sure your last commit about the line size is really merged ... I don't know why but this changes wasn't there when I downloaded your branch ... I had to manually add the piece of code in Handles.cs script to make it works.

@JoelFortin
Copy link
Contributor

Forget what I said about the script missing your changes ... just realized I used the scripts that was in the attached project and not your new version of the script from the package. Fire Away !!

@karl- karl- merged commit ef0abc3 into master Oct 8, 2019
@karl- karl- deleted the samples/fix-runtime-editing-standalone branch October 8, 2019 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants