Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/1258589 sample runtime example error #308

Merged
merged 3 commits into from
Jul 9, 2020

Conversation

lopezt-unity
Copy link
Collaborator

DO NOT FORGET TO INCLUDE A CHANGELOG ENTRY

Purpose of this PR

Modification in samples to handle API update
(Error on import otherwise)

Links

Fogbugz: https://fogbugz.unity3d.com/f/cases/1258589/

Comments to Reviewers

[List known issues, planned work, provide any extra context for your code.]

Copy link
Contributor

@JoelFortin JoelFortin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Although I needed to have a certain setup in order to repro the error in the console. Anyhow, at least it's consistent now.

@lopezt-unity lopezt-unity merged commit 10576a2 into master Jul 9, 2020
@karl- karl- deleted the bugfix/1258589-sample-runtime-example-error branch July 9, 2020 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants