Bug fixes/oct8 2020 #344
Merged
Bug fixes/oct8 2020 #344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 18 commits
October 8, 2020 12:39
…ty Editor and ProGrids
…ooth group window open
… HDRP shader variants
|
Validated all the related cases with their fogbugz description. All pretty safe except for the polyshape snapping on grid, I played around with this around for a while and seems pretty fine to me. |
JoelFortin
approved these changes
Oct 16, 2020
karl-
commented
Oct 16, 2020
| Pref<float> m_BevelSize = new Pref<float>("BevelEdges.size", .2f); | ||
|
|
||
| public override ToolbarGroup group { get { return ToolbarGroup.Geometry; } } | ||
| public override Texture2D icon { get { return IconUtility.GetIcon("Toolbar/Edge_Bevel", IconSkin.Pro); } } | ||
| public override TooltipContent tooltip { get { return s_Tooltip; } } | ||
|
|
||
| static readonly GUIContent gc_BevelDistance = new GUIContent("Distance", "The size of the bevel in meters."); |
antoine-unity
approved these changes
Oct 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Collection of bug fixes
Links
NullReferenceException thrown when Redo operation is performed with Smooth Group Editor window
Poly Shape vertices do not snap to the grid
Center Pivot tooltip contains a typo
Bevel Settings slider goes of bounds when a value larger than 1 is used
ArgumentNullException on replacing a prefab while exporting it from ProBuilder window
Object face numbers are slightly cut from the left side in the Smooth Group Editor window
Tooltip is missing for the properties in the Smooth Group Editor window
ProBuilder Objects do not update their Mesh Colliders in Editor when the Object's Mesh is modified
Comments to Reviewers
[List known issues, planned work, provide any extra context for your code.]