Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed notebook, dataset, docker config, removed yacs #154

Merged
merged 9 commits into from
Mar 2, 2021
Merged

Fixed notebook, dataset, docker config, removed yacs #154

merged 9 commits into from
Mar 2, 2021

Conversation

86sanj
Copy link
Contributor

@86sanj 86sanj commented Mar 1, 2021 •
edited
Loading

Peer Review Information

This commit includes following changes:

  1. Refract SynDetection2D to fix the notebook.
  2. Removed yacs lib
  3. Included docker build fixes (Fixed cryptography rust dependency #150)
  4. Update README to reflect the current high level API with instructions to show how to use this package

Requirement: #143

  • Added tests for changed code.
  • Updated documentation for changed code.

@86sanj 86sanj changed the title Fixed notebook, dataset, docker config, removed yas Fixed notebook, dataset, docker config, removed yacs Mar 1, 2021
@86sanj 86sanj mentioned this pull request Mar 1, 2021
Closed
5 tasks
BlairLee
BlairLee reviewed Mar 1, 2021
View reviewed changes
README.md Show resolved Hide resolved
@86sanj 86sanj requested a review from romerocesar March 2, 2021 00:07
romerocesar
romerocesar previously approved these changes Mar 2, 2021
View reviewed changes
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
datasetinsights/datasets/synthetic.py Show resolved Hide resolved
BlairLee
BlairLee previously approved these changes Mar 2, 2021
View reviewed changes
@86sanj 86sanj requested a review from BlairLee March 2, 2021 19:01
BlairLee
BlairLee previously approved these changes Mar 2, 2021
View reviewed changes
BlairLee
BlairLee reviewed Mar 2, 2021
View reviewed changes
README.md Show resolved Hide resolved
@86sanj 86sanj requested a review from BlairLee March 2, 2021 20:08
@86sanj 86sanj merged commit 8b34c43 into master Mar 2, 2021
@86sanj 86sanj deleted the notebook-readme-fix branch March 2, 2021 20:57
adason
adason reviewed Mar 8, 2021
View reviewed changes
Dockerfile Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adason adason adason left review comments

@BlairLee BlairLee BlairLee approved these changes

@Saurav-D Saurav-D Saurav-D approved these changes

@romerocesar romerocesar Awaiting requested review from romerocesar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@86sanj @romerocesar @adason @BlairLee @Saurav-D