Switch s3 to use only AWS Signature Version 4 #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While s3 states it supports AWS Signature Version 2 this is not the case as it requires custom changes such as Expires parameter, so the previous change which uses the common AWS Signature Version 2 caused failures. Follow the official AWS SDK in using only Signature Version 4, which is now supported everywhere, to avoid using the old custom s3 Signature Version 2 implementation. Also expose the option to enable debugging by switching const debug to var Debug.
|
👍 |
stevenh
added a commit
that referenced
this pull request
Jul 30, 2015
Switch s3 to use only AWS Signature Version 4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While s3 states it supports AWS Signature Version 2 this is not the case as it requires custom changes such as Expires parameter, so the previous change which uses the common AWS Signature Version 2 caused failures.
Follow the official AWS SDK in using only Signature Version 4, which is now supported everywhere, to avoid using the old custom s3 Signature Version 2 implementation.
Also expose the option to enable debugging by switching const debug to var Debug.