CDSK-928 - ensure that why.getTraceback will be on Failure object

Unity-Technologies · May 14, 2018 · 09b0b47 · 09b0b47
1 parent 863aae6
commit 09b0b47
Showing 1 changed file with 1 addition and 0 deletions.
diff --git a/master/buildbot/process/buildstep.py b/master/buildbot/process/buildstep.py
@@ -807,6 +807,7 @@ def failed(self, why):
                 if isinstance(why.type, str):
                     klog.err_json("Failure.type is string: [name: %s] [builder: %s] " %
                                   (self.name, self.build))
+                    why = Failure(why)  # ensure CopiedFailure -> Failure
                     why.type = locate(why.type) or why.type
                 self.addCompleteLog("err.text", why.getTraceback())
                 self.addHTMLLog("err.html", formatFailure(why))