This repository has been archived by the owner on May 24, 2018. It is now read-only.
Fixed incorrect links to artifacts for UTR run on windows #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -27,7 +27,7 @@ | |||
| <div class="clearfix"></div> | |||
| {% for artifact in suite.artifacts %} | |||
| <div class="artifact"> | |||
| <a target="_blank" href="{{ join(path_to_artifacts, artifact) }}">{{ basename(artifact) }}</a> | |||
| <a target="_blank" href="{{ join(path_to_artifacts, artifact).replace("\\","/") }}">{{ basename(artifact.replace("\\","/")) }}</a> | |||
There was a problem hiding this comment.
You might want to use urlparse.urljoin instead.
That is assuming that we can pass urljoin to this (jinja?) template, and that path_to_artifacts does not contain \ already :)
There was a problem hiding this comment.
No, path_to_artifacts will never contain '', the artifact can have '', urljoin works the same way as path join, it doesn't replace backslashes to forwardslashes when joins
kkateq
pushed a commit
that referenced
this pull request
Feb 29, 2016
…report-win-links-hotfix Fixed incorrect links to artifacts for UTR run on windows
mariangemarcano
deleted the
vKatana2.1.x/feature/report-win-links-hotfix
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JSON provide artifacts relative links in windows style format now when UTR run on windows, so the links to artifacts became broken for such reports