This repository has been archived by the owner on May 24, 2018. It is now read-only.
forked from buildbot/buildbot
-
Notifications
You must be signed in to change notification settings - Fork 31
[CDSK-554] Change the confirmation text from 'stop this build' button #352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
warcholprzemo
approved these changes
Apr 12, 2018
"Are you sure you want to cancel?" Can we change the text on those buttons? I guess the better modal screen makes sense sooner than later :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Goo job
warcholprzemo
approved these changes
Apr 23, 2018
campos-ddc
approved these changes
Apr 23, 2018
60268ce
to
8f70f23
Compare
8f70f23
to
fe21d08
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
'Stop this build' should have confirmation text which describes the action of this button
New stop build dialog:
![stop_build](https://user-images.githubusercontent.com/4771380/39117544-765f0986-46e7-11e8-8e97-3bcb761f0166.png)
New stop entire build chain dialog
![stop_entire_build_chain](https://user-images.githubusercontent.com/4771380/39117547-78bfd296-46e7-11e8-87c8-b53678867af2.png)