Skip to content
This repository has been archived by the owner on May 24, 2018. It is now read-only.

[CDSK-554] Change the confirmation text from 'stop this build' button #352

Merged
merged 4 commits into from
Apr 30, 2018

Conversation

Mowinski
Copy link

@Mowinski Mowinski commented Apr 11, 2018

'Stop this build' should have confirmation text which describes the action of this button

New stop build dialog:
stop_build

New stop entire build chain dialog
stop_entire_build_chain

progress

@Mowinski Mowinski self-assigned this Apr 11, 2018
@coveralls
Copy link

Coverage Status

Coverage remained the same at 68.531% when pulling c910230 on cdsk-554-confirmation-text into 460306a on staging.

@coveralls
Copy link

coveralls commented Apr 11, 2018

Coverage Status

Coverage remained the same at 68.622% when pulling fe21d08 on cdsk-554-confirmation-text into 98e0e99 on staging.

@campos-ddc
Copy link
Member

"Are you sure you want to cancel?"
Cancel / OK

Can we change the text on those buttons? I guess the better modal screen makes sense sooner than later :)

@campos-ddc
Copy link
Member

I think that the "No" button should use the standard grey color, like these:

image

@Mowinski
Copy link
Author

Small update
buttons

Copy link

@warcholprzemo warcholprzemo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Goo job

@warcholprzemo warcholprzemo merged commit 0afd7cf into staging Apr 30, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants