This repository has been archived by the owner on May 24, 2018. It is now read-only.
[CDSK-969] Improve Katana-UI for many projects #368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mowinski
changed the title
|
I'd change the text to "Filter results" instead of "Filter projects", since it seems that we always use "results" in our other filter bars |
Mowinski
force-pushed
the
cdsk-969-project-autocomplete
branch
from
d727b14
to
c992f4a
Compare
|
Updated :) |
|
Looks great! Make sure to test it on phones / small screens |
campos-ddc
approved these changes
May 16, 2018
Mowinski
force-pushed
the
cdsk-969-project-autocomplete
branch
from
3f4a950
to
1cb57a2
Compare
| allProjects = response.map(function(item) { | ||
| return item.name; | ||
| }); | ||
| maxPage = allProjects.length / maxShowedItems; |
There was a problem hiding this comment.
This variable is unused (and has "float" after division). Please, remove it.
| <div class="dataTables_paginate" style="width: 100%; text-align: center;"> | ||
| <a id="prev-projects" class="paginate_button previous" href="#">Prev</a> | ||
| <a href="/projects" class="paginiate_button">All projects</a> | ||
| <a id="next-projects" class="paginate_button next" href="#">Next</a> |
There was a problem hiding this comment.
.paginate_button is not used in CSS or JS
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screenshot: