Make Gym interface work with grayscale and RGB visual observations #2192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hi @shakenes - can you change the branch to Develop from Master? |
|
hi @shakenes - just a friendly reminder to change your target branch to Develop. We do not accept direct contributions to Master in this way. |
|
Sorry for the delay. Just changed it! |
|
thank you for your contribution @shakenes! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi everybody,
I recently ran into issues when processing multiple visual observations that contain both, RGB and grayscale images, with the OpenAI Gym interface.
I edited the
_single_stepfunction accordingly and now it should work.What do you think?
Sorry for the second PR. Apparently, something went wrong with my git settings...