multi-gpu ppo #2288
Merged
multi-gpu ppo #2288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gies/ml-agents into develop-multi-gpu
|
|
harperj
suggested changes
Jul 19, 2019
harperj
reviewed
Jul 23, 2019
harperj
reviewed
Jul 23, 2019
harperj
suggested changes
Jul 24, 2019
vincentpierre
suggested changes
Jul 24, 2019
harperj
reviewed
Jul 26, 2019
There was a problem hiding this comment.
This is looking a lot better to my eyes. I think you'll want to at least make sure we get some unit test coverage on the core pieces of the MultiGpuPPOPolicy code-- update, average_gradients, and get_devices. It should now be easier to mock out construct_feed_dict so that you can be sure your update function behaves as you'd expect.
harperj
approved these changes
Jul 29, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add multi-gpu ppo training