Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop barracuda tensor #2308

Merged
merged 15 commits into from
Jul 24, 2019
Merged

Develop barracuda tensor #2308

merged 15 commits into from
Jul 24, 2019

Conversation

mantasp
Copy link
Contributor

@mantasp mantasp commented Jul 22, 2019

Bringing bucket of temp memory allocation optimizations:

  • switched to Barracuda backed tensor across the board, helps to leverage allocators and reuse of the internal buffers
  • added Barracuda 0.2.4 release, which bring another set of temp memory allocation fixes

@CLAassistant
Copy link

CLAassistant commented Jul 22, 2019

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ chriselion
❌ Mantas Puida


Mantas Puida seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@mantasp mantasp requested a review from ervteng July 22, 2019 12:42
@mantasp mantasp changed the base branch from master to develop July 22, 2019 15:03
@chriselion
Copy link
Contributor

@mantasp That merge conflict was due to fixing line endings in that file (#2208). IIRC it touched the whole file.

* develop: (69 commits)
  Add different types of visual encoder (nature cnn/resnet)
  Make SubprocessEnvManager take asynchronous steps (#2265)
  update mypy version
  one more unused
  remove unused variables
  Fix respawn part of BananaLogic (#2277)
  fix whitespace and line breaks
  remove codacy (#2287)
  Ported documentation from other branch
  tennis reset parameter implementation ported over
  Fixed the default value to match the value in the docs
  two soccer reset parameter implementation ported over
  3D ball reset parameter implementation ported over
  3D ball reset parameter implementation ported over
  Relax the cloudpickle version restriction (#2279)
  Fix get_value_estimate and buffer append (#2276)
  fix lint checks
  Add Unity command line arguments
  Swap 0 set and reward buffer append (#2273)
  GAIL and Pretraining (#2118)
  ...
@mantasp
Copy link
Contributor Author

mantasp commented Jul 22, 2019

@chriselion fixed!

@ervteng
Copy link
Contributor

ervteng commented Jul 22, 2019

I tested all of the usual suspects (Visual, Discrete Actions (+ Branched), Continuous Actions, LSTM) and they all seem to work fine.

@ervteng ervteng merged commit 8fd352b into develop Jul 24, 2019
@chriselion chriselion deleted the develop-barracuda-tensor branch July 25, 2019 16:19
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants