Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash in construct_curr_info when next_info doesn't have any agents #2549

Merged
merged 2 commits into from
Sep 13, 2019
Merged

Fix crash in construct_curr_info when next_info doesn't have any agents #2549

merged 2 commits into from
Sep 13, 2019

Conversation

ervteng
Copy link
Contributor

@ervteng ervteng commented Sep 13, 2019

Fixes #1687

vincentpierre
vincentpierre approved these changes Sep 13, 2019
View reviewed changes
Copy link
Contributor

@vincentpierre vincentpierre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like a line of comment to explain why we check if memories exists

@ervteng
Copy link
Contributor Author

ervteng commented Sep 13, 2019

Added comment

@ervteng ervteng merged commit 0a2a095 into develop Sep 13, 2019
@ervteng ervteng deleted the develop-fixmemories branch September 13, 2019 17:06
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chriselion chriselion chriselion approved these changes

@vincentpierre vincentpierre vincentpierre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ervteng @chriselion @vincentpierre