Messages will be consumed when the side channel registers #3573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriselion
reviewed
Mar 5, 2020
| @@ -504,6 +504,19 @@ public void RegisterSideChannel(SideChannel sideChannel) | |||
| "A side channel with type index {0} is already registered. You cannot register multiple " + | |||
| "side channels of the same id.", channelId)); | |||
| } | |||
|
|
|||
| for (int i = 0; i< m_CachedMessages.Count; i++) | |||
There was a problem hiding this comment.
I need to think about this more, but you might need to save m_CachedMessages.Count at the start of the loop since it can decrease as you iterate.
For example, I think if you have 2 cached messages that match the channel ID, you'll only process 1 - the second time through the loop, i and m_CachedMessages.Count will both be 1.
There was a problem hiding this comment.
Arg ! I did not think of that. You are right, the number should be fixed before the loop
There was a problem hiding this comment.
In general, I get scared about iterating over a data structure while modifying it. I think freezing the count outside the loop will be safe though.
chriselion
reviewed
Mar 5, 2020
chriselion
approved these changes
Mar 5, 2020
Co-Authored-By: Chris Elion <chris.elion@unity3d.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change(s)
Messages will be consumed when the side channel registers
Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)
Types of change(s)
Checklist
Other comments