[refactor] Add --tensorflow, enable Torch as default setting #4582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincentpierre
approved these changes
Oct 19, 2020
| @@ -169,10 +169,10 @@ def _create_parser() -> argparse.ArgumentParser: | |||
| help="Forces training using CPU only", | |||
| ) | |||
| argparser.add_argument( | |||
There was a problem hiding this comment.
I think we should still have --torch but raise a warning saying it is useless and it will be removed in a future release.
Similarly, we should raise a warning if the user is using --tensorflow as it will be deprecated in a future release.
There was a problem hiding this comment.
Added the warnings and --torch back
added 2 commits
October 19, 2020 16:00
10 tasks
ervteng
pushed a commit
that referenced
this pull request
Oct 21, 2020
* Torch setup.py * Set torch to default * Make torch default in setup.py * Remove indents * Remove other instances of TF being used * Add tensorboard to setup.py * Adding correst setup commands for verifying torch is installed (#4524) * Adding correst setup commands for verifying torch is installed * Editing the test_requirments to add tf and remove torch * Develop torchdefault raise outside setup (#4530) * Torch not imported error to raise at first usage * Torch not imported error to raise at first usage * [refactor] Use PyTorch TensorBoard utils (#4518) * Convert stats writer to use PyTorch TB support * Use common function to print params * Update test * Bump tensorboard to 1.15 to fix the tests * putting tensorboard 1.15.0 as min version requirement Co-authored-by: vincentpierre <vincentpierre@unity3d.com> * [Docs] Initial documentation changes for making Torch the default (#4561) * Initial commit * Forgotten doc * Removing the `Installation-Anaconda-Windows.md` as it is deprecated * Readding the depreacted Installation-Anaconda-Windows.md but leaving it unchanged * more references to tensorflow removed * Update README.md Co-authored-by: Ervin T. <ervin@unity3d.com> * Change references to .nn to .onnx in docs (#4583) Co-authored-by: Ervin T. <ervin@unity3d.com> * [refactor] Add --tensorflow, enable Torch as default setting (#4582) * Add --tensorflow option * Switch framework to Pytorch default * Update changelog * Re-add --torch * Edit warning * Modify Yamato tests (#4584) * Don't check for PB file in Yamato inference * Only run inference on ONNX * Update docs/Unity-Inference-Engine.md with correct tf2onnx versions Co-authored-by: Chris Elion <chris.elion@unity3d.com> * Add reward signal class comments * More descriptive import of is_available * Updated installation instructions for PyTorch * More reward signal comments * More Windows instructions Co-authored-by: Vincent-Pierre BERGES <vincentpierre@unity3d.com> Co-authored-by: Chris Elion <chris.elion@unity3d.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change(s)
Add a
--tensorflowoption to revert back to TensorFlow.Also actually changes the default framework in settings to PyTorch, and adds a changelog entry.
Note:
pip install mlagents[tensorflow]was already added in the branch.Types of change(s)
Checklist
Other comments