Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove pylint #4836

Merged
merged 3 commits into from
Jan 8, 2021
Merged

remove pylint #4836

merged 3 commits into from
Jan 8, 2021

Conversation

chriselion
Copy link
Contributor

@chriselion chriselion commented Jan 8, 2021

Proposed change(s)

Most things that pylint catches are also caught by e.g. flake8 or mypy. There are several false positives (pylint-dev/pylint#3876, pylint-dev/pylint#2377) and false/random negatives (pylint-dev/pylint#2893) that make it more annoying than helpful.

Remove pylint from pre-commit config, and remove all workaround scattered in the code.

Types of change(s)

  • Bug fix

Copy link
Contributor

@ervteng ervteng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@chriselion chriselion merged commit 8d62720 into master Jan 8, 2021
@delete-merged-branch delete-merged-branch bot deleted the remove-pylint branch January 8, 2021 23:07
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants