Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional logic to avoid load being called on every advance #4934

Merged
merged 3 commits into from
Feb 10, 2021

Conversation

andrewcoh
Copy link
Contributor

@andrewcoh andrewcoh commented Feb 10, 2021

Proposed change(s)

#4931

I think i can still clean this up but im running on the cloud to see if we get a speedup/ensure correctness.

Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)

Types of change(s)

  • Bug fix
  • New feature
  • Code refactor
  • Breaking change
  • Documentation update
  • Other (please describe)

Checklist

  • Added tests that prove my fix is effective or that my feature works
  • Updated the changelog (if applicable)
  • Updated the documentation (if applicable)
  • Updated the migration guide (if applicable)

Other comments

Copy link
Contributor

@dongruoping dongruoping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good if the cloud experiments results also said so

@andrewcoh andrewcoh merged commit c56c617 into master Feb 10, 2021
@delete-merged-branch delete-merged-branch bot deleted the fix-load-weights branch February 10, 2021 23:07
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants