Multiagent simplerl #5066
Merged
Multiagent simplerl #5066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| pass | ||
|
|
||
| def set_actions(self, behavior_name, action): | ||
| # im so sorry |
| @@ -314,6 +314,185 @@ def _make_batched_step( | |||
| return (decision_step, terminal_step) | |||
|
|
|||
|
|
|||
| class MultiAgentEnvironment(BaseEnv): | |||
There was a problem hiding this comment.
I understand nothing this class does. Please add comments
There was a problem hiding this comment.
Yeah, it is a pretty horrible thing
|
|
||
| # tests in this file won't be tested on GPU machine | ||
| pytestmark = pytest.mark.check_environment_trains | ||
|
|
||
|
|
||
| @pytest.mark.parametrize("action_sizes", [(0, 1), (1, 0)]) |
There was a problem hiding this comment.
Can this be tested for combinations of rank 1, 2 and 3 observations and with and LSTM config? (To make sure it does not crash at least)
There was a problem hiding this comment.
Added some tests for LSTM, variable length obs, and visual
vincentpierre
approved these changes
Mar 10, 2021
| self.dones[name_and_num] = False | ||
| self.envs[name_and_num].reset() | ||
| # HACK | ||
| self.behavior_spec = self.envs[name_and_num].behavior_spec |
There was a problem hiding this comment.
This dos not need to be in the loop
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change(s)
Describe the changes made in this PR.
Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)
Types of change(s)
Checklist
Other comments