Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[馃悰 馃敤 ]Adding the ELO to the GlobalTrainingStatus #5202

Merged
merged 2 commits into from Mar 31, 2021
Merged

[馃悰 馃敤 ]Adding the ELO to the GlobalTrainingStatus #5202

merged 2 commits into from Mar 31, 2021

Conversation

vincentpierre
Copy link
Contributor

@vincentpierre vincentpierre commented Mar 30, 2021 •
edited

Proposed change(s)

Use the GlobalTrainingStatus to save the current ELO

Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)

Types of change(s)

  • Bug fix
  • New feature
  • Code refactor
  • Breaking change
  • Documentation update
  • Other (please describe)

Checklist

  • Added tests that prove my fix is effective or that my feature works
  • Updated the changelog (if applicable)
  • Updated the documentation (if applicable)
  • Updated the migration guide (if applicable)

Other comments

@vincentpierre vincentpierre self-assigned this Mar 30, 2021
@vincentpierre vincentpierre changed the title Adding the ELO to the GlobalTrainingStatus [馃悰 馃敤 ]Adding the ELO to the GlobalTrainingStatus Mar 30, 2021
andrewcoh
andrewcoh approved these changes Mar 31, 2021
View reviewed changes
Copy link
Contributor

@andrewcoh andrewcoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this a draft? LGTM

@vincentpierre @andrewcoh
Update ml-agents/mlagents/trainers/ghost/trainer.py
84f343c 
Co-authored-by: andrewcoh <54679309+andrewcoh@users.noreply.github.com>
@vincentpierre vincentpierre marked this pull request as ready for review March 31, 2021 15:57
@vincentpierre vincentpierre merged commit 9c3dc45 into main Mar 31, 2021
@delete-merged-branch delete-merged-branch bot deleted the fix-elo-resume branch March 31, 2021 20:28
ervteng pushed a commit that referenced this pull request Apr 8, 2021
@vincentpierre
[馃悰 馃敤 ]Adding the ELO to the GlobalTrainingStatus (#5202)
7fae873 
* Adding the ELO to the GlobalTrainingStatus

* Update ml-agents/mlagents/trainers/ghost/trainer.py

Co-authored-by: andrewcoh <54679309+andrewcoh@users.noreply.github.com>

Co-authored-by: andrewcoh <54679309+andrewcoh@users.noreply.github.com>
(cherry picked from commit 9c3dc45)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@andrewcoh andrewcoh andrewcoh approved these changes

Assignees

@vincentpierre vincentpierre

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vincentpierre @andrewcoh