Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add doc for custom GridSensor #5282

Merged
merged 1 commit into from
Apr 19, 2021
Merged

Add doc for custom GridSensor #5282

merged 1 commit into from
Apr 19, 2021

Conversation

dongruoping
Copy link
Contributor

Proposed change(s)

Add documentation for how to derive from GridSensorBase and intro for CountingGridSensor.

Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)

Types of change(s)

  • Bug fix
  • New feature
  • Code refactor
  • Breaking change
  • Documentation update
  • Other (please describe)

Checklist

  • Added tests that prove my fix is effective or that my feature works
  • Updated the changelog (if applicable)
  • Updated the documentation (if applicable)
  • Updated the migration guide (if applicable)

Other comments

chriselion
chriselion approved these changes Apr 19, 2021
View reviewed changes
Copy link
Contributor

@chriselion chriselion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just not sure if it should go in the extensions documentation or the general docs.

@dongruoping
Copy link
Contributor Author

Looks good, just not sure if it should go in the extensions documentation or the general docs.

Since it mentioned CountingGridSensor and limitations around normalization and compression, I think it would be better to keep in the extension.

@dongruoping dongruoping merged commit a37410b into main Apr 19, 2021
@delete-merged-branch delete-merged-branch bot deleted the develop-gridsensor-doc branch April 19, 2021 17:44
dongruoping added a commit that referenced this pull request Apr 19, 2021
@dongruoping
Add doc for deriving from grid sensor base (#5282)
3c4a1bc
@dongruoping dongruoping mentioned this pull request Apr 19, 2021
Merged
10 tasks
dongruoping added a commit that referenced this pull request Apr 19, 2021
@dongruoping
Add doc for deriving from grid sensor base (#5282) (#5292)
417c51d
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chriselion chriselion chriselion approved these changes

@surfnerd surfnerd Awaiting requested review from surfnerd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dongruoping @chriselion