Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove MaxStep from Soccer agents #5310

Merged
merged 1 commit into from Apr 23, 2021
Merged

Remove MaxStep from Soccer agents #5310

merged 1 commit into from Apr 23, 2021

Conversation

chriselion
Copy link
Contributor

@chriselion chriselion commented Apr 22, 2021 •
edited

Proposed change(s)

Soccer Agents had a maxStep of 3000, but the SoccerEnvController would also reset the Agents when a goal was scored or after MaxEnvironmentSteps.

This sets the MaxStep of all Soccer prefab agents to 0.

Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)

https://forum.unity.com/threads/some-advice-and-suggestions-python-status-maxstep-vs-maxenvironmentsteps-and-ray-sensor-useage.1097416/

Types of change(s)

  • Bug fix
  • New feature
  • Code refactor
  • Breaking change
  • Documentation update
  • Other (please describe)

Checklist

  • Added tests that prove my fix is effective or that my feature works
  • Updated the changelog (if applicable)
  • Updated the documentation (if applicable)
  • Updated the migration guide (if applicable)

Other comments

@chriselion chriselion merged commit b629b49 into release_17_branch Apr 23, 2021
@delete-merged-branch delete-merged-branch bot deleted the r17-fix-soccer-maxSteps branch April 23, 2021 00:33
vincentpierre pushed a commit that referenced this pull request Apr 27, 2021
@chriselion @vincentpierre
remove MaxStep from Soccer agents (#5310)
ac38b6b
vincentpierre pushed a commit that referenced this pull request Apr 27, 2021
@chriselion @vincentpierre
remove MaxStep from Soccer agents (#5310)
aa4de95
vincentpierre pushed a commit that referenced this pull request Apr 27, 2021
@chriselion @vincentpierre
remove MaxStep from Soccer agents (#5310)
8db2dd2
@chriselion chriselion mentioned this pull request Jun 7, 2021
Merged
1 task
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dongruoping dongruoping dongruoping approved these changes

@andrewcoh andrewcoh andrewcoh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@chriselion @dongruoping @andrewcoh