Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editing the GridSensor documentation for 2D use case #5396

Merged
merged 2 commits into from May 26, 2021
Merged

Editing the GridSensor documentation for 2D use case #5396

merged 2 commits into from May 26, 2021

Conversation

vincentpierre
Copy link
Contributor

Proposed change(s)

Grid Sensor does not work in 2D environments because we do a projection on the x,z plane.

Useful links (Github issues, JIRA tickets, ML-Agents forum threads etc.)

Types of change(s)

  • Bug fix
  • New feature
  • Code refactor
  • Breaking change
  • Documentation update
  • Other (please describe)

Checklist

  • Added tests that prove my fix is effective or that my feature works
  • Updated the changelog (if applicable)
  • Updated the documentation (if applicable)
  • Updated the migration guide (if applicable)

Other comments

@vincentpierre vincentpierre self-assigned this May 26, 2021
@vincentpierre vincentpierre merged commit 39da84f into main May 26, 2021
@delete-merged-branch delete-merged-branch bot deleted the fix-doc-gridsensor-2d branch May 26, 2021 19:19
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dongruoping dongruoping dongruoping approved these changes

Assignees

@vincentpierre vincentpierre

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vincentpierre @dongruoping