Add option to use stevedore or ono for external build deps #1095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashwinimurt
changed the title
ashwinimurt
force-pushed
the
use-stevedore-production
branch
2 times, most recently
from
98a75f4
to
311256c
Compare
ashwinimurt
force-pushed
the
use-stevedore-production
branch
from
311256c
to
8bf9554
Compare
ashwinimurt
changed the title
joshpeterson
approved these changes
Dec 5, 2018
joncham
approved these changes
Dec 6, 2018
joncham
approved these changes
Dec 6, 2018
joncham
approved these changes
Dec 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does the following:
Point
externalBuildDepsto stevedore artifacts directory, instead of copying the downloaded artifacts to$monoroot/../../mono-build-deps/build/(The copy step is unnecessary and had the overhead of keeping track of downloaded files so we can pass them as input to the copy action.)
Add
--stevedorebuilddeps=1/0option to build scripts. The default is set to 0 (don't break Katana until config changes land). Update gitlabCI config to pass in stevedorebuilddeps=1.Change autoconf, automake, texinfo, libtool to point to 'public' repo.
Use bokken-runners are Android, OSX runtime and Classlibs build.
Upcoming PR to use bokken for windows and linux after we have resolved all issues.
Passing GitlabCI pipeline: https://gitlab.cds.internal.unity3d.com/vm/mono/pipelines/12496
Passing Katana run: https://katana.bf.unity3d.com/projects/Mono%20Runtime%20and%20Classlibs/builders?boo_branch=unity-trunk&cecil_branch=unity-master&krait-signal-handler_branch=master&mono_branch=use-stevedore-production&mono-build-tools-extra_branch=master&mono-build-deps_branch=default&unityscript_branch=unity-trunk
Note: This does not affect current build process on Katana because all changes are behind a
if(stevedorebuilddeps)option. and the default is set to 0.Unless we pass in
--stevedorebuilddeps=1to the perl scripts (as part of upcoming Katana PR), we will still be using ono for mono-build-deps.