Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set using stevedoreBuildDeps as default #1103

Merged
merged 1 commit into from
Dec 13, 2018

Conversation

ashwinimurt
Copy link

  1. Windows runtime builds do not use any build-deps. There is no need to pull them down. This will save a lot of time!

  2. The workflow was to run Bee to pull down artifacts BEFORE running the perl script.
    In this PR, have build.pl run Bee IF it was not run before running the perl script.

  3. Make stevedoreBuildDeps=1 default. We don't have to pass in --stevedorebuilddeps=1 anymore. It wouldn't hurt to pass it in for clarity, so I kept it in the Gitlab CI config.

Tested here https://gitlab.cds.internal.unity3d.com/vm/mono/pipelines/13901

@joshpeterson We don't have to backport any of the stevedore related changes now. On Katana configs, I will remove --stevedorebuilddeps=1, which means

  • On backport branches, it will just pull down build-deps from ono.
  • On unity-master, it will use stevedore. Does this sounds good?

@joshpeterson
Copy link

Yes, I think this approach will work.

@ashwinimurt
Copy link
Author

Katana changes landed, so I will merge this.

@ashwinimurt ashwinimurt merged commit 9f4d362 into unity-master Dec 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants