Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warning crash #1163

Merged
merged 1 commit into from
Mar 11, 2019
Merged

Fix warning crash #1163

merged 1 commit into from
Mar 11, 2019

Conversation

joshpeterson
Copy link

The format string was incorrect in this case, which leads to this crash
in Unity:

https://crashes.hq.unity3d.com/crashes/5aa00d01b4db11000de20c8e?versions_range=2018.3.5..2019.2.99&date_start=&date_end=&source=

Simply remove the unused %s format specifier here.

I'm planing to back port this change to 2019.1 and 2018.3.

Release notes:

Mono: Fix an intermittent crash in strnlen, from the selector_thread_wakeup_drain_pipes function.

I'll also upstream this fix once it lands in our repo.

The format string was incorrect in this case, which leads to this crash
in Unity:

https://crashes.hq.unity3d.com/crashes/5aa00d01b4db11000de20c8e?versions_range=2018.3.5..2019.2.99&date_start=&date_end=&source=

Simply remove the unused `%s` format specifier here.
@joncham
Copy link
Member

joncham commented Mar 11, 2019

This is still an issue upstream. We should open PR there too https://github.com/mono/mono/blob/master/mono/metadata/threadpool-io.c#L201

@joshpeterson
Copy link
Author

Yes, I'll fix this upstream as well.

@joshpeterson joshpeterson merged commit acf432a into unity-master Mar 11, 2019
@joshpeterson joshpeterson deleted the fix-warning-crash branch March 11, 2019 17:03
@joshpeterson
Copy link
Author

I've back ported this to 2019.1 at: 256ceb9

@joshpeterson
Copy link
Author

I've back ported this to 2018.3 at: 9022a35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants