New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo #1198

Merged

ashwinimurt merged 1 commit into unity-master from fix-typo-eq

Jun 27, 2019

ashwinimurt commented Jun 27, 2019

No description provided.


          Fix typo

283390a

ashwinimurt requested a review from UnityAlex

June 27, 2019 17:20

UnityAlex reviewed

View reviewed changes

external/buildscripts/build_win_no_cygwin.pl

@@ @@ -39,7 +39,7 @@ @@
               my $buildDeps = "";
               my $stevedoreBuildDeps=1;
-              if($ENV{YAMATO_PROJECT_ID} || ($ENV{USERNAME} == "bokken"))
+              if($ENV{YAMATO_PROJECT_ID} || ($ENV{USERNAME} eq "bokken"))

Collaborator

UnityAlex Jun 27, 2019

I also think if you want to see if YAMAO_PROJECT_ID is set then you'll want to do something like: if (defined $ENV{'YAMATO_PROJECT_ID'} || ...

UnityAlex approved these changes

View reviewed changes

ashwinimurt merged commit 1bc3c9a into unity-master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment