Wait for debugger thread to exit (case 1180399, case 1189077) #1234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is logic to ensure debugger thread is shutting down before we continue, but thread has not actually exited. This leaves us open to race conditions in profiler events and thread info machinery that are cleaned up by runtime shutdown.
|
Do we need release notes for this change? |
joshpeterson
approved these changes
Oct 9, 2019
|
Added release notes @joshpeterson |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is logic to ensure debugger thread is shutting down
before we continue, but thread has not actually exited. This
leaves us open to race conditions in profiler events and
thread info machinery that are cleaned up by runtime shutdown.
Release Notes:
case 1180399 - Fix crash on shutdown in debugger thread.
case 1189077 - Fix crash on shutdown in mono_profiler_raise_thread_stopped.