Changes to use artifacts from stevedore unity-internal #1290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashwinimurt
commented
May 6, 2020
| @@ -124,10 +119,10 @@ private static void RegisterCommonNonWindowsArtifacts() | |||
| "autoconf-src/2.69_0e4ba7a0363c68ad08a7d138b228596aecdaea68e1d8b8eefc645e6ac8fc85c7.7z", | |||
| "public")); | |||
|
|
|||
| Artifacts.Add("libgdiplus", | |||
| Artifacts.Add("libgdiplus-mac", | |||
There was a problem hiding this comment.
I am not sure where this is used. I could not find this path being used in build.pl.
There was a problem hiding this comment.
I think we used to copy it into the build.7z. Perhaps we don't bother anynmore?
joncham
approved these changes
May 7, 2020
ashwinimurt
force-pushed
the
stevedore-internal
branch
from
a9f6a55
to
1b9de54
Compare
|
Backported to 2020.1, 2019.3 & 2018.4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Build.bee.csand use the one that is already pulled down by bee.This removes use of stevedore testing, and hopefully prevents download failures.