Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pickup BDWGC fix for GC_retry_signals performance regression (case 1255866) #1311

Merged

Conversation

scott-ferguson-unity
Copy link

No description provided.

@joncham
Copy link
Member

joncham commented Jul 1, 2020

Why does bdwgc diff look so big? But if I click there is no difference?

@scott-ferguson-unity scott-ferguson-unity force-pushed the unity-master-fix-bdwgc-perf-regression branch from 341e798 to 53de59e Compare July 1, 2020 16:55
@scott-ferguson-unity
Copy link
Author

Messed up which branch the submodule was on - it was reverted to an older commit (my local bdgwc submodules unity-master instead of being up to date with origin/unity-master. Which is why all the tests failed.

This does also pull in @joshpeterson Emscripten fix, which should affect mono.

@scott-ferguson-unity scott-ferguson-unity force-pushed the unity-master-fix-bdwgc-perf-regression branch from 53de59e to af4eda6 Compare July 2, 2020 13:21
@scott-ferguson-unity scott-ferguson-unity merged commit c867676 into unity-master Jul 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants