Use mono_runtime_invoke to invoke finalizers. #1316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e can do whatever is necessary to transition to executing managed code, like marking JIT memory executable on macOS ARM64.
|
I'm going to test this in ABV before merging. |
joncham
approved these changes
Jul 11, 2020
…lvirt Finalize() on the object and if it didn't have a finalizer, it would call Object::Finalize(). However, since now we use mono_method_invoke with a concrete method, we crash if it's null. So we just
|
Everything looks great on Unity's side. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On macOS ARM64, you're supposed to mark JIT memory executable before you invoke it. Currently, when invoking finalizers, we invoke JITed code directly from "gc.c", which means we don't have a chance to switch to executable mode.
To fix this, I changed gc.c to go through mono_runtime_invoke. That way all the setup can be done there. It fixes the issue completely.