The fix for 1256569 broke a test. Partial revert #1322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UnityAlex
force-pushed
the
unity-master-fix-xb1-timezone
branch
from
2623bd0
to
567e5f4
Compare
UnityAlex
changed the title
UnityAlex
changed the title
UnityAlex
force-pushed
the
unity-master-fix-xb1-timezone
branch
2 times, most recently
from
e0530f3
to
3ddcd59
Compare
TautvydasZilys
approved these changes
Jul 22, 2020
…reaking the CreateLocal -> WinRTFallback -> CreateLocal loop by calling GetLocalTimeZoneInfoWinRTFallback instead of accessing Local from within FindSystemTimeZoneByIdWinRTFallback fixes both issues. Need to make sure we don't duplicate the timezone and create a new local when we already have one.
UnityAlex
force-pushed
the
unity-master-fix-xb1-timezone
branch
from
3ddcd59
to
a54323f
Compare
joncham
approved these changes
Jul 22, 2020
TautvydasZilys
approved these changes
Jul 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverting most of that change and breaking the CreateLocal -> WinRTFallback -> CreateLocal loop by calling GetLocalTimeZoneInfoWinRTFallback instead of accessing Local from within FindSystemTimeZoneByIdWinRTFallback fixes both issues.
Partial revert of: https://github.com/Unity-Technologies/mono/pull/1310/files