Fixed bug with multiClient option, and fixed the test that was writte…

…n incorrectly that would have caught the bug to begin with.
Unity-Technologies · May 17, 2018 · 6ee0d83 · 6ee0d83
1 parent cb93af7
commit 6ee0d83
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/lib/cache/reliability_manager.js b/lib/cache/reliability_manager.js
@@ -49,7 +49,6 @@ class ReliabilityManager {
         const entry = this.getEntry(params.guidStr, params.hashStr, true);
         if(!entry.versionHash) {
             entry.versionHash = params.versionHashStr;
-            entry.clientId = params.clientId;
         }
 
         if(entry.state !== ReliabilityManager.reliabilityStates.Pending) {

diff --git a/test/reliability_manager.js b/test/reliability_manager.js
@@ -153,7 +153,6 @@ describe("ReliabilityManager", () => {
                 const myRm = new ReliabilityManager(db, tmp.tmpNameSync(), { reliabilityThreshold: 2, multiClient: true });
                 const guid = randomBuffer(consts.GUID_SIZE);
                 const hash = randomBuffer(consts.HASH_SIZE);
-                await myRm.processTransaction(new StablePutTransaction(guid, hash));
 
                 const trx = new StablePutTransaction(guid, hash);
                 trx.clientAddress = "A";
@@ -162,6 +161,10 @@ describe("ReliabilityManager", () => {
                 const entry = rm.getEntry(helpers.GUIDBufferToString(trx.guid), trx.hash.toString('hex'));
                 assert.equal(entry.state, ReliabilityManager.reliabilityStates.Pending);
 
+                trx.clientAddress = "A";
+                await myRm.processTransaction(trx);
+                assert.equal(entry.state, ReliabilityManager.reliabilityStates.Pending);
+
                 trx.clientAddress = "B";
                 await myRm.processTransaction(trx);
                 assert.equal(entry.state, ReliabilityManager.reliabilityStates.ReliableNew);