Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

[pr] minimize log message string allocations #117

Merged
merged 4 commits into from Apr 23, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions lib/helpers.js
Expand Up @@ -5,7 +5,7 @@ const path = require('path');
const fs = require('fs-extra');
const ip = require('ip');

let logLevel = consts.LOG_TEST;
let logLevel = consts.LOG_INFO;

reverseByte = (b) => ((b & 0x0F) << 4) | ((b >> 4) & 0x0F);

Expand Down Expand Up @@ -143,8 +143,8 @@ exports.readDir = readDir;
* @param {String} msg
*/
exports.log = exports.defaultLogger = (lvl, msg) => {
if (lvl <= logLevel)
console.log(`${msg}`);
if(lvl > logLevel) return;
console.log(msg);
};

/**
Expand Down
4 changes: 2 additions & 2 deletions lib/server/server.js
Expand Up @@ -82,7 +82,7 @@ class CacheServer {
this.errCallback = errCallback;

this._server = net.createServer(socket => {
helpers.log(consts.LOG_TEST, `${socket.remoteAddress}:${socket.remotePort} connected.`);
helpers.log(consts.LOG_INFO, `${socket.remoteAddress}:${socket.remotePort} connected.`);

const cmdProc = new CommandProcessor(this.cache);
const streamProc = new ClientStreamProcessor({clientAddress: `${socket.remoteAddress}:${socket.remotePort}`});
Expand All @@ -95,7 +95,7 @@ class CacheServer {
}

socket.on('close', () => {
helpers.log(consts.LOG_TEST, `${socket.remoteAddress}:${socket.remotePort} closed connection.`);
helpers.log(consts.LOG_INFO, `${socket.remoteAddress}:${socket.remotePort} closed connection.`);
socket.unpipe(streamProc);
streamProc.unpipe(cmdProc);
cmdProc.unpipe(socket);
Expand Down
5 changes: 4 additions & 1 deletion test/test_init.js
@@ -1,8 +1,11 @@
const helpers = require('../lib/helpers');
const consts = require('../lib/constants');

require('cluster').setMaxListeners(25);

process.on('unhandledRejection', (reason) => {
console.error(reason);
});

helpers.setLogger(() => {});
helpers.setLogger(() => {});
helpers.setLogLevel(consts.LOG_DBG);